[RFC PATCH 4/6] ARM: kernel: update cpu_suspend code to use cache LoUIS operations

Russell King - ARM Linux linux at arm.linux.org.uk
Thu Sep 13 09:08:11 EDT 2012


On Thu, Sep 13, 2012 at 06:31:35PM +0530, Shilimkar, Santosh wrote:
> In the series, there is patch "[PATCH 3/6]" which adds an
> API which let you operate on a specific level.

Which is introduced but as far as I can see, is never used in the patch
set.  Therefore, it shouldn't be introduced.

We've been here before many many many times, where people introduce stuff
into the kernel, and then they never get around to using the damned stuff.
It's happened far too many times to permit on a "but I will use it in the
future" kind of arguments.

If you're going to introduce something new, include the users in the patch
set, or don't bother submitting the new function in the vague hope that
some day it will get used.



More information about the linux-arm-kernel mailing list