[PATCH 7/7] ARM: OMAP2+: PM: reorganize the powerdomain API in public and private parts

Jean Pihet jean.pihet at newoldbits.com
Thu Sep 13 03:29:25 EDT 2012

On Thu, Sep 13, 2012 at 2:11 AM, Kevin Hilman
<khilman at deeprootsystems.com> wrote:
> Jean Pihet <jean.pihet at newoldbits.com> writes:
>> The newly added code for functional power states re-defines the
>> API to query and control the power domains settings.
>> The API is now split in the following parts in powerdomain.h:
>> - the public or external API, to be used by external PM components:
>>   cpuidle, suspend, pmxxxx, clock* etc.
>> - the private or internal API, to be used by the low level PM code
>>   only: powerdomain*, pm-debug, hwmod, voltage, clockdomainxxxx.
>> The function omap_set_pwrdm_state is not used anymore and so is
>> removed.
>> No functional change is introduced by this patch.
>> Note: the API reorganization in a public and private header files
>> is not part of this patch, this comes as a subsequent clean-up
>> patch series.
>> Signed-off-by: Jean Pihet <j-pihet at ti.com>
> In addition to reorganizing the API, I suspect there are a handful of
> out-of-tree hacks, er, users, that will are using the internal state
> names, as well as the functions that should now only be internal.
The API clean-up series (planned after this one is in the queue) will
sort out the public vs private APIs using different header files and
static functions.

> As part of the subsequent cleanup series, it would it make sense to add
> a '_' prefix to the internal names as well to catch unintentional use of
> internal APIs?

> Kevin


More information about the linux-arm-kernel mailing list