[PATCH 1/3] ARM: Remove bcmring NAND driver

Olof Johansson olof at lixom.net
Wed Sep 12 14:55:09 EDT 2012


On Wed, Sep 12, 2012 at 11:39 AM, Christian Daudt <csd at broadcom.com> wrote:
> On 12-09-12 10:25 AM, Stephen Warren wrote:
>>
>> On 09/12/2012 02:16 AM, Christian Daudt wrote:
>>>
>>> This driver is being removed as part of the cleanup of the bcmring
>>> SoC from mainline as it is no longer maintained.
>>>   arch/arm/configs/bcmring_defconfig |    2 -
>>
>> Out of curiosity, if you're removing the whole thing, why edit the
>> defconfig at all; just delete it instead in whatever patch removes the
>> arch/arm parts?
>>
> I figured it'd be better to remove the config portion on this patch so it is
> self-contained - just in case the other patch gets held up for some reason
> then this one can still be applied and no junk would be left around. But
> agreed - it doesn't really affect things either way.

Just skip the defconfig update in this patch -- if the Kconfig option
goes away then the build system will just ignore it even if it's in
the defconfig. Also, if you touch it here and remove it in the other
patch you might end up getting a conflict due to the file removal when
things go upstream, which is just extra churn.


-Olof



More information about the linux-arm-kernel mailing list