[PATCH v4] Add basic address decoding support for Marvell 370/XP

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Tue Sep 11 11:45:01 EDT 2012


Le Tue, 11 Sep 2012 13:10:00 +0000,
Arnd Bergmann <arnd at arndb.de> a écrit :

> Excellent!
> Acked-by: Arnd Bergmann <arnd at arndb.de>

Related to this patch set, I have a question: wouldn't it make sense to
make the .virtual field of struct map_desc anvoid __iomem pointer as
well instead of an unsigned long? This would avoid all the (unsigned
long) casts in map_descs array definitions, and would be a bit more
consistent, no?

Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.

More information about the linux-arm-kernel mailing list