[PATCH 1/5] arm: plat-orion: use 'void __iomem *' in addr-map code

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Tue Sep 11 08:54:31 EDT 2012


Jason,

Le Sun, 9 Sep 2012 16:45:19 -0400,
Jason Cooper <jason at lakedaemon.net> a écrit :

> I just wanted to make sure this came to your attention.  While
> discussing the finer points of branch management for pull requests,
> Olof had the following comments regarding this patch:
> 
> > >       arm: plat-orion: use 'void __iomem *' in addr-map code
> > 
> > Hmm, I would prefer if the actual constants were annotated instead
> > of cast in the code here. See how we handled that on tegra with
> > IOMEM(). That will also help sparse catch unannotated uses of those
> > constants.
> 
> Could you please take a look at this?  I assume the rest of this
> series relies on this patch, so I'm holding off until it's resolved.

Sorry for the delay, I was busy working on the Marvell Armada
370/XP network driver. I have now posted a 17 patches series that
should hopefully address Olof's comment (version 4 of this patch
series).

Thanks!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com



More information about the linux-arm-kernel mailing list