[PATCH v4 15/21] serial: omap: unlock the port lock

Felipe Balbi balbi at ti.com
Thu Sep 6 08:45:34 EDT 2012

From: Ruchika Kharwar <ruchika at ti.com>

This patch unlocks the port lock before calling a serial_core API
and re-acquires the port lock after calling it.
This patch fixes a system freeze issue seen when the serial_core
API uart_write_wakeup() eventually attempts to acquire the port lock
already acquired by omap serial interrupt handler.

Tested-by: Shubhrajyoti D <shubhrajyoti at ti.com>
Signed-off-by: Ruchika Kharwar <ruchika at ti.com>
Signed-off-by: Pavan Savoy <pavan_savoy at ti.com>
Signed-off-by: Vijay Badawadagi <bvijay at ti.com>
Signed-off-by: Felipe Balbi <balbi at ti.com>
 drivers/tty/serial/omap-serial.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
index d244163..9e4419c 100644
--- a/drivers/tty/serial/omap-serial.c
+++ b/drivers/tty/serial/omap-serial.c
@@ -224,8 +224,11 @@ static void transmit_chars(struct uart_omap_port *up, unsigned int lsr)
 	} while (--count > 0);
-	if (uart_circ_chars_pending(xmit) < WAKEUP_CHARS)
+	if (uart_circ_chars_pending(xmit) < WAKEUP_CHARS) {
+		spin_unlock(&up->port.lock);
+		spin_lock(&up->port.lock);
+	}
 	if (uart_circ_empty(xmit))

More information about the linux-arm-kernel mailing list