[PATCH] ARM: Fix deadlock scenario with smp_send_stop()

Stephen Boyd sboyd at codeaurora.org
Wed Sep 5 17:01:26 EDT 2012

If one process calls sys_reboot and that process then stops other
CPUs while those CPUs are within a spin_lock() region we can
potentially encounter a deadlock scenario like below.

CPU 0                   CPU 1
-----                   -----
 send_IPI               handle_IPI()
spin_lock(my_lock) <--- Waits forever

We shouldn't attempt to run any other tasks after we send a stop
IPI to a CPU so disable preemption so that the reboot task runs to

Reported-by: Sundarajan Srinivasan <sundaraj at codeaurora.com>
Signed-off-by: Stephen Boyd <sboyd at codeaurora.org>

Unfortunately this won't fix the other problem I mentioned two weeks
ago where smp_send_stop races with other CPUs calling cpu_up().

 arch/arm/kernel/process.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
index 693b744..663a7a8 100644
--- a/arch/arm/kernel/process.c
+++ b/arch/arm/kernel/process.c
@@ -239,6 +239,7 @@ __setup("reboot=", reboot_setup);
 void machine_shutdown(void)
+	preempt_disable();
 #ifdef CONFIG_SMP
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation

More information about the linux-arm-kernel mailing list