[PATCH v3 3/3] cpufreq: Add a generic cpufreq-cpu0 driver
Rafael J. Wysocki
rjw at sisk.pl
Wed Sep 5 09:38:12 EDT 2012
On Wednesday, September 05, 2012, Shawn Guo wrote:
> On Wed, Sep 05, 2012 at 01:18:38AM +0200, Rafael J. Wysocki wrote:
> > On Friday, August 10, 2012, Shawn Guo wrote:
> > > It adds a generic cpufreq driver for CPU0 frequency management based on
> > > clk, regulator, OPP and device tree support. It can support both
> > > uniprocessor (UP) and those symmetric multiprocessor (SMP) systems which
> > > share clock and voltage across all CPUs.
> > >
> > > Signed-off-by: Shawn Guo <shawn.guo at linaro.org>
> > I seem to recall that this has been discussed with several people and
> > undergone some changes as a result of comments. Would it be possible
> > to get some ACKs from the people involved?
> Mark, Santosh,
> Reviewed-by, please?
> Tested-by, please?
> > > --- /dev/null
> > > +++ b/drivers/cpufreq/cpufreq-cpu0.c
> > > @@ -0,0 +1,271 @@
> > > +/*
> > > + * Copyright (C) 2012 Freescale Semiconductor, Inc.
> > > + *
> > > + * Reuse some codes from drivers/cpufreq/omap-cpufreq.c
> > What do you mean by "reuse" here?
> cpu0_set_target() function is almost a copy of omap_target() from
> drivers/cpufreq/omap-cpufreq.c. I should probably just say so?
Well, what about actually avoiding the code duplication? That is,
can you make OMAP be a user of your new core function and drop the
OMAP-specific one, perhaps?
More information about the linux-arm-kernel