[PATCH 05/11] ARM: shmobile: r8a7779: add USB common phy initializer
kuninori.morimoto.gx at renesas.com
Mon Sep 3 20:21:22 EDT 2012
Hi Arnd, Simon
> > From: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
> > This patch adds common USB phy ports initializer for r8a7779.
> > The note is that each USB IP have own MSTP clock bit,
> > and common USB phy port doesn't have MSTP clock,
> > but this USB phy needs USB clock.
> > Each USB driver / platform should keep USB MSTP clock somehow.
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
> > Signed-off-by: Simon Horman <horms at verge.net.au>
> > ---
> > arch/arm/mach-shmobile/include/mach/common.h | 1 +
> > arch/arm/mach-shmobile/setup-r8a7779.c | 93 ++++++++++++++++++++++++++++
> > 2 files changed, 94 insertions(+)
> Shouldn't the USB PHY driver go to drivers/usb/phy/ or
> We are trying hard to move driver code out of the platform and into driver
> directories these days, and having it wired up as part of the platform
> the way you do also means it is always powered on.
I can move this code to under driver.
Can I send additional patch for it ?
- move usb phy code to driver (to Simon, USB ML)
Or should I send multi patches ?
- remove this patch (to Simon)
- add usb phy driver patch (to USB ML)
- use usb phy driver patch (to Simon)
> I see neither big-endian support on shmobile, nor any XHCI (USB-3.0) driver, just
> the old EHCI (USB-2.0) and OHCI (USB-1.1) drivers. Are you submitting the XHCI
> support and big-endian platform code separately?
Sorry for very confusing naming.
I fix it
More information about the linux-arm-kernel