[PATCH 02/10] gpio: pxa: add explicit includes for cpu_is_X macros

[Haojian Zhuang]

On Fri, Aug 31, 2012 at 6:17 AM, Linus Walleij <linus.walleij at linaro.org> wrote:
> On Wed, Aug 29, 2012 at 3:31 PM, Rob Herring <robherring2 at gmail.com> wrote:
>
>> From: Rob Herring <rob.herring at calxeda.com>
>>
>> In preparation to remove implicit inclusion of mach/gpio.h, add the
>> necessary includes for cpu_is_X macros.
>
> The commit message talks about gpio.h, but...
>
>>  #include <mach/irqs.h>
>> +#include <mach/hardware.h>
>> +#ifdef CONFIG_ARCH_MMP
>> +#include <mach/cputype.h>
>> +#endif
>
> This seems completely unrelated, but correct in the sense that every driver
> should include its resources.
>
> But isn't the proper fix to move arch/arm/mach-pxa/include/mach/cputype.h to
> include/linux/*/pxa-cputype.h or something (note: no clue what "*" should be!),
> or even better, modify this one driver to take a flag from platform data and/or
> DT?
>
> Anyway, we need the PXA maintainers to look at this.
>
> Yours,
> Linus Walleij

It's no problem to include cputype.h. I agree Linus's comments to use a same
name head file. For example, add cputype.h in arch-pxa. Use cputype.h to include
hardware.h.

My question is whether your patches are also based on Arnd's
multi-header branch.
I remember that some changes are done in his multiplatform branch. Should we
do any patches on his multiplatform branch?