[PATCH] ASoC: SAMSUNG: Add SND_SOC_DAIFMT_CONT option for snd_soc_set_fmt()

[Sangsu Park]

On Sun, Aug 31, 2012 at 2:43 AM +0900, Mark Brown wrote:
> On Wed, Aug 29, 2012 at 08:06:32PM +0900, Sangsu Park wrote:
> 
> Please check your mailer configuration, it looks like it's reformatting
> all the text with much longer line widths.

I've changed line width configuration. Is it ok now?

> 
> > On Sun, Aug 26, 2012 at 05:45:54PM +0900, Mark Brown wrote:
> 
> > > a whole lot of sense on the slave side, it's related to the clock
> generation so should have no
> > > effect at all on the slave side.  The driver code looks reasonably
> sensible though.
> 
> > You mean cpu side is slave?
> 
> Yes.

But, Samsung pcm is working only for cpu master. 

> 
> 
> > > What specifically is going wrong here?
> 
> > SND_SOC_DAIFMT_CONT is used sound/soc/Samsung/pcm.c (s3c_pcm_set_fmt()) like
> below.
> 
> > switch (fmt & SND_SOC_DAIFMT_CLOCK_MASK) {
> >         case SND_SOC_DAIFMT_CONT:
> >                 pcm->idleclk = 1;
> >                 break;
> >         case SND_SOC_DAIFMT_GATED:
> >                 pcm->idleclk = 0;
> >                 break;
> >         default:
> >                 dev_err(pcm->dev, "Invalid Clock gating request!\n");
> >                 ret = -EINVAL;
> >                 goto exit;
> >         }
> 
> > If fmt argument has no SND_SOC_DAIFMT_ option, s3c_pcm_set_fmt() return -
> EINVAL.
> 
> So, clearly this is unrelated to the change you mentioned in your commit
> message - it looks like this is just a plain issue in the machine
> driver.  That said the above code should be changed to at least ignore
> the setting in slave mode (since the clock shouldn't be being driven and
> it doesn't matter).

Do you think that changing pcm driver is right approach?
Then I'll fix pcm driver. (I think that pcm driver has some strange code.)

> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel