[PATCH 1/3] irqchip: Move ARM GIC to drivers/irqchip

Russell King - ARM Linux linux at arm.linux.org.uk
Wed Oct 31 11:07:39 EDT 2012

On Wed, Oct 31, 2012 at 09:29:19AM -0500, Rob Herring wrote:
> What about other asm header dependencies? cpu_logical_map is needed for
> example. I guess I'll leave all those for now.

That's one of the down-sides to moving this code out of arch/arm - your
existing set of five patches adds to the required asm headers (eg, it
now needs set_smp_cross_call() from ARMs asm/smp.h, whereas it didn't
need that before) and any SMP architecture re-using the GIC will need
to provide this function whether or not they use the SPI facility.

Further comments against your patch set...

More information about the linux-arm-kernel mailing list