[PATCH] mvebu-gpio: Disable blinking when enabling a GPIO for output

Linus Walleij linus.walleij at linaro.org
Tue Oct 30 18:16:26 EDT 2012


On Sun, Oct 28, 2012 at 1:23 PM, Jamie Lentin <jm at lentin.co.uk> wrote:

> The plat-orion GPIO driver would disable any pin blinking whenever
> using a pin for output. Do the same here, as a blinking LED will
> continue to blink regardless of what the GPIO pin level is.
>
> Signed-off-by: Jamie Lentin <jm at lentin.co.uk>
> ---
> The power LED on the DNS-320/DNS-325 is left blinking by the bootloader,
> the LED turning steady indicates it's booted. The blinking needs to be
> disabled before setting the GPIO pin level has any effect.
>
> Apart from the custom init code running too soon, I think everything is
> working now.
>
> I haven't tested this on any other boards, so not sure if it's sensible
> beyond the kirkwood/orion world.

Can I have some ACK on this thing from Andrew or Thomas say...

Also is this a thing for the stable kernel -rc series or next
merge window? I couldn't quite figure out if it was a regression.

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list