[PATCH] Fix socfpga compilation with early_printk() enabled

Pavel Machek pavel at denx.de
Sat Oct 27 07:56:16 EDT 2012


Hi!

> > This fixes early_printk() compilation for
> > socfpga. (senduart/busyuart/waituart were missing). It does that by
> > making Picochip code generic.
> > 
> > Signed-off-by: Pavel Machek <pavel at denx.de>
> > Acked-by: Dinh Nguyen <dinguyen at altera.com>
> > Acked-by: Jamie Iles <jamie at jamieiles.com 
> 
> Applied to fixes branch of arm-soc, but please be more explicit about
> what you want to happen with patches in the future. Ideally we would
> get pull requests for patches on each platform from only one person,
> so please coordinate with Dinh Nguyen who that should be.

Dinh is the maintainer, so if we can only send patches from one
person, it needs to be him. If you'd be willing to take patches from
second person, that would help us... if not, of course I can send all
the patches through Dinh.

> Some minor things:
> 
> * If you include something in the email that should not be part of
> the git changelog (e.g. "Hi!"), then please put it below the "---"
> line under the Signed-off list.

Ok.

> * you are missing a '>' after Jamies email address

Sorry.

> * When you submit a patch for inclusion, please always take both
> Olof and me on Cc on the email, since we are doing this work together
> and take turns, so you might not always know which one will take
> the patch. We have an alias "arm at kernel.org" that you can also
> use.

Olof Johansson <olof at lixom.net>? Can do.

But... perhaps you should add an entry into MAINTAINERS file
explaining all this? arm at kernel.org is not mentioned there, Olof is
not mentioned as maintaining arm. (And yes, I did check it before
original patch submission).

Thanks,
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html



More information about the linux-arm-kernel mailing list