[PATCH] ARM: OMAP1: usb: fix sparse warnings
Tony Lindgren
tony at atomide.com
Fri Oct 26 17:28:41 EDT 2012
* Paul Walmsley <paul at pwsan.com> [121026 14:27]:
> On Fri, 26 Oct 2012, Tony Lindgren wrote:
>
> > * Paul Walmsley <paul at pwsan.com> [121026 13:54]:
> > >
> > > Resolve the following sparse warnings:
> > >
> > > arch/arm/mach-omap1/usb.c:304:12: warning: symbol 'omap1_usb0_init' was not declared. Should it be static?
> > > arch/arm/mach-omap1/usb.c:412:12: warning: symbol 'omap1_usb1_init' was not declared. Should it be static?
> > > arch/arm/mach-omap1/usb.c:478:12: warning: symbol 'omap1_usb2_init' was not declared. Should it be static?
> > >
> > > by declaring those functions as static. Also remove the unneeded
> > > prototypes and related code from the plat/usb.h header file.
> > >
> > > Signed-off-by: Paul Walmsley <paul at pwsan.com>
> > > Cc: Tony Lindgren <tony at atomide.com>
> > > Cc: Felipe Balbi <balbi at ti.com>
> > > ---
> > >
> > > Tony, care to take this one?
> >
> > Let's apply just the usb.c changes on omap-for-v3.8/cleanup-headers
> > as plat/usb.h is now gone?
>
> OK no problem, thought you might want it for the -rc series...
Looks like it's not urgent for the -rc series, so let's not
introduce more self-inflicted merge conflicts. If that's OK
with you, I can apply it to omap-for-v3.8/cleanup-headers
without the header changes.
Regards,
Tony
More information about the linux-arm-kernel
mailing list