[RFC][PATCH 0/5] Introduce .get_voltage callback into voltdm
khilman at deeprootsystems.com
Fri Oct 26 14:17:51 EDT 2012
Mike Turquette <mturquette at ti.com> writes:
> From: Mike Turquette <mturquette at linaro.org>
> This series creates a new callback for struct voltagedomain,
> .get_voltage. This fetches the voltage from hardware, if possible, and
> returns it to the caller. We use this call to populate
> voltdm->nominal_volt at boot time.
I pointed out a couple nitpicky things on individual patches, but
otherwise this direction and motiviation for this series looks OK by me.
Just some minor comments about the structure of the series. I tend to
prefer combining the introduction of a new function with it's usage. It
makes review and understanding much easier, IMO. If there are reasons
to keep them separate, that's fine too. Just describe the reasons in
the cover letter.
More information about the linux-arm-kernel