[PATCH v2 5/7] crypto: omap-sham: Convert to use pm_runtime API

Mark A. Greer mgreer at animalcreek.com
Fri Oct 26 13:10:09 EDT 2012

On Thu, Oct 25, 2012 at 05:34:02PM -0700, Kevin Hilman wrote:
> Hi Mark,

Hi Kevin.

> "Mark A. Greer" <mgreer at animalcreek.com> writes:
> > From: "Mark A. Greer" <mgreer at animalcreek.com>
> >
> > Convert the omap-sham crypto driver to use the
> > pm_runtime API instead of the clk API.
> >
> > CC: Kevin Hilman <khilman at deeprootsystems.com>
> > CC: Paul Walmsley <paul at pwsan.com>
> > CC: Dmitry Kasatkin <dmitry.kasatkin at intel.com>
> > Signed-off-by: Mark A. Greer <mgreer at animalcreek.com>
> I can't pretend to fully understand this driver, It looks like the
> current code is doing a bit more fine-grained clock gating, and leaving
> the IP clocked only when needed.
> The proposed version does a 'get' in probe and a 'put' in remove, which
> means the IP will always be enabled (and thus preventing low-power
> states), even when it's not in use.

You're right, and what I did is wrong.  I'll fix this in the next revision.



More information about the linux-arm-kernel mailing list