[PATCH 5/7] ARM: OMAP2+: WDT: move init; add read_reset_sources pdata function pointer

Paul Walmsley paul at pwsan.com
Thu Oct 25 15:57:31 EDT 2012


On Thu, 25 Oct 2012, Tony Lindgren wrote:

> I have not looked how the watchdog subsystem handles multiple
> watchdogs, but..

In the new watchdog core code, each watchdog driver gets a separate 
/dev/watchdog* character device.  The ioctls are called on those device 
nodes.

[ As an aside, neither the OMAP watchdog driver, nor the TWL watchdog 
driver have been updated to use the new watchdog core code.  So they both 
can't be loaded at the same time until one or both are fixed. ]

> Can't we have the omap watchdog and twl watchdog return -ENOTSUPP for 
> WDIOC_GETBOOTSTATUS and have the watchdog core fail over to the third 
> wathcdog omap_prcm_wdt_ioctl() that only implements WDIOC_GETBOOTSTATUS? 
> Or something like that.

Sounds like a question better asked of Alan Cox and Wim, who wrote the 
watchdog core code.

Two other observations:

- It's possible that two different watchdogs could report different boot 
reasons.  The TWL might store its own watchdog boot reason which could be 
different from what's reported via the OMAP PRM.  For example, the TWL can 
record a thermal shutdown reset event, STS_BOOT.TS, which wouldn't be 
reflected in the PRM reset source data, which would just see some kind of 
external reset or power-off event.

- The PRM doesn't contain a hardware watchdog, so not sure it makes sense 
to create a watchdog driver for it.


- Paul



More information about the linux-arm-kernel mailing list