[PATCH 5/7] ARM: OMAP2+: WDT: move init; add read_reset_sources pdata function pointer

Aaro Koskinen aaro.koskinen at iki.fi
Thu Oct 25 11:38:05 EDT 2012


On Mon, Oct 15, 2012 at 07:32:33PM -0600, Paul Walmsley wrote:
> The OMAP watchdog timer driver directly calls a function exported by
> code in arch/arm/mach-omap2.  This is not good; it tightly couples
> this driver to the mach-omap2 integration code.  Instead, add a
> temporary platform_data function pointer to abstract this function
> call.  A subsequent patch will convert the watchdog driver to use this
> function pointer.

Why a function is needed? Reset cause won't change until the next reset,
so it should be enough to read it once during the init and store it into
the platform data.


More information about the linux-arm-kernel mailing list