[PATCH 2/5] ARM: Kirkwood: Allow use of MVEBU GPIO driver.

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Thu Oct 25 04:57:21 EDT 2012


Dear Andrew Lunn,

On Wed, 24 Oct 2012 16:25:21 +0200, Andrew Lunn wrote:

>  config GPIO_MVEBU
>  	def_bool y
> -	depends on ARCH_MVEBU
> +	depends on ARCH_MVEBU || ARCH_KIRKWOOD
>  	select GPIO_GENERIC
>  	select GENERIC_IRQ_CHIP

Should we turn the depends on ARCH_MVEBU into a depends on PLAT_ORION,
like I did for the pinctrl driver (patch accepted by Linus Walleij
yesterday) ? I think the dependency on ARCH_MVEBU was making too much
of a shortcut, by assuming that we would very quickly move everybody
into mach-mvebu. As we rather decided to move gradually
mach-{kirkwood,dove,orion5x,mv78xx0} to those infrastructure while
keeping them in their respective directories, I think a dependency on
PLAT_ORION is more appropriate here.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com



More information about the linux-arm-kernel mailing list