[PATCH 3/5] pinctrl: dove: fix iomem and pdma clock
linus.walleij at linaro.org
Thu Oct 25 03:04:06 EDT 2012
On Wed, Oct 24, 2012 at 4:25 PM, Andrew Lunn <andrew at lunn.ch> wrote:
> Since 3.7 readl/writel require register addresses to be const void*
> instead of unsigned int. The register addresses are converted using
> IOMEM() and offsets are added instead of OR'ed.
> Also a workaround for the pdma clock is added, that is required as
> there is still no DT clock provider available on Dove.
So essentially two unrelated patches squashed into one, and I
would apply the first one right off but now the clock change makes
> clk = devm_clk_get(&pdev->dev, NULL);
> + /* Currently there is no DT clock provider for pdma clock,
> + this fallback ensures pdma clock is ticking */
* I prefer comment style like so because it's easier to read.
* Maybe it's a bit pedantic but bear with me.
> + if (IS_ERR(clk))
> + clk = clk_get_sys("dove-pdma", NULL);
This is a horrible hack. But if the Marvell people agree about
it I will live with it.
More information about the linux-arm-kernel