[PATCH 2/3] dmaengine: sirf: fix a typo in moving running dma_desc to active queue
Vinod Koul
vkoul at infradead.org
Wed Oct 24 07:03:31 EDT 2012
On Thu, 2012-09-27 at 16:36 +0800, Barry Song wrote:
> From: Barry Song <Baohua.Song at csr.com>
>
> list_move_tail(&schan->queued, &schan->active) makes the list_empty(schan->queued)
> undefined, we either should change it to:
> list_move_tail(schan->queued.next, &schan->active)
> or
> list_move_tail(&sdesc->node, &schan->active)
>
> Signed-off-by: Barry Song <Baohua.Song at csr.com>
> ---
> drivers/dma/sirf-dma.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/dma/sirf-dma.c b/drivers/dma/sirf-dma.c
> index 35a329d..c439489 100644
> --- a/drivers/dma/sirf-dma.c
> +++ b/drivers/dma/sirf-dma.c
> @@ -109,7 +109,7 @@ static void sirfsoc_dma_execute(struct sirfsoc_dma_chan *schan)
> sdesc = list_first_entry(&schan->queued, struct sirfsoc_dma_desc,
> node);
> /* Move the first queued descriptor to active list */
> - list_move_tail(&schan->queued, &schan->active);
> + list_move_tail(&sdesc->node, &schan->active);
>
> /* Start the DMA transfer */
> writel_relaxed(sdesc->width, sdma->base + SIRFSOC_DMA_WIDTH_0 +
applied thanks
--
Vinod Koul
Intel Corp.
More information about the linux-arm-kernel
mailing list