Possible regression in arm/io.h
hechtb at googlemail.com
Wed Oct 24 06:38:14 EDT 2012
your introduction of the "+Qo" in arch/arm/include/asm/io.h makes some
drivers fail to compile on newer gnu ARM gccs. Like in
drivers/mtd/nand/docg4.c there is an offset of 0x800 from a pointer
used to address I/O memory. This leads to the error message:
/tmp/ccwLMdCy.s: Error: bad immediate value for 8-bit offset (2048)
The gnu gcc people tracked it down to the asm directive "+Qo". Do we
really want to enforce to allow only addresses that are offsetable
with one byte? If I understand it correctly from the gnu gcc docs, the
"o" is doing this.
excerpt from asm/io.h:
static inline void __raw_writew(u16 val, volatile void __iomem *addr)
asm volatile("strh %1, %0"
: "+Qo" (*(volatile u16 __force *)addr)
: "r" (val));
So do we want to remove the "o" from all __raw_readX and __raw_writeX
functions? I've tried it and stuff compiles again without errors.
More information about the linux-arm-kernel