[PATCH] gpio: mvebu: correctly set the value in direction_output()

Linus Walleij linus.walleij at linaro.org
Wed Oct 24 01:37:10 EDT 2012

On Tue, Oct 23, 2012 at 10:17 AM, Thomas Petazzoni
<thomas.petazzoni at free-electrons.com> wrote:

> The ->direction_output() operation of gpio_chip is supposed to set the
> direction to output but also to set the GPIO to an initial
> value. Unfortunately, this last part was not done until now, causing
> for example the LEDs to not be properly set to their default initial
> value. This patch fixes this by calling the mvebu_gpio_set() function
> from mvebu_gpio_direction_output() before configuring the GPIO as an
> output GPIO.
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
> ---
> As this is a fix, it should most likely go into 3.7.

Yes, thanks. Applied to my "fixes" branch.

Linus Walleij

More information about the linux-arm-kernel mailing list