[RFC] ARM: OMAP: hwmod: wait for sysreset complete after enabling hwmod

Shubhrajyoti Datta omaplinuxkernel at gmail.com
Tue Oct 23 11:43:56 EDT 2012


On Tue, Oct 23, 2012 at 3:16 AM, Kevin Hilman
<khilman at deeprootsystems.com> wrote:
> Tero Kristo <t-kristo at ti.com> writes:
>
>> When waking up from off-mode, some IP blocks are reset automatically by
>> hardware. For this reason, software must wait until the reset has
>> completed before attempting to access the IP block.
>>
>> This patch fixes for example the bug introduced by commit
>> 6c31b2150ff96755d24e0ab6d6fea08a7bf5c44c ("mmc: omap_hsmmc: remove access
>> to SYSCONFIG register"), in which the MMC IP block is reset during
>> off-mode entry, but the code expects the module to be already available
>> during the execution of context restore.
>>
>> Signed-off-by: Tero Kristo <t-kristo at ti.com>
>> Cc: Paul Walmsley <paul at pwsan.com>
>> Cc: Benoit Cousson <b-cousson at ti.com>
>> Cc: Venkatraman S <svenkatr at ti.com>
>
> I can confirm that this patch the regression in my OMAP3 PM tests where
> suspend test (to retention or off) failed if ran after the off-idle
> test.
>
> Tested-by: Kevin Hilman <khilman at ti.com>
>
> on 3530/Overo, 3730/OveroSTORM, 3730/Beagle-xM

on 3630/Beagle works.
However on 3430 on idle path didnot work.
let me know if i am missing some thing.

>
> Thanks Tero for the fix,
>
> Kevin
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



More information about the linux-arm-kernel mailing list