[PATCH] ARM: OMAP3: Beagle: fix OPP customization and initcall ordering

Tony Lindgren tony at atomide.com
Mon Oct 22 17:26:56 EDT 2012


* Kevin Hilman <khilman at deeprootsystems.com> [121022 13:35]:
> --- a/arch/arm/mach-omap2/board-omap3beagle.c
> +++ b/arch/arm/mach-omap2/board-omap3beagle.c
> @@ -24,6 +24,7 @@
>  #include <linux/input.h>
>  #include <linux/gpio_keys.h>
>  #include <linux/opp.h>
> +#include <linux/cpu.h>
>  
>  #include <linux/mtd/mtd.h>
>  #include <linux/mtd/partitions.h>
> @@ -444,12 +445,13 @@ static struct omap_board_mux board_mux[] __initdata = {
>  };
>  #endif
>  
> -static void __init beagle_opp_init(void)
> +static int __init beagle_opp_init(void)
>  {
>  	int r = 0;

Don't you need to add some check here for machine_is
to prevent this from running on other boards if you now
make this into an initcall?

Regards,

Tony



More information about the linux-arm-kernel mailing list