Do we need to fix below dump during cpu hot plug operation?
Russell King - ARM Linux
linux at arm.linux.org.uk
Fri Oct 19 05:40:27 EDT 2012
On Fri, Oct 19, 2012 at 11:37:48AM +0200, Linus Walleij wrote:
> @@ -93,6 +94,8 @@ static void twd_timer_stop(struct clock_event_device *clk)
> {
> twd_set_mode(CLOCK_EVT_MODE_UNUSED, clk);
> disable_percpu_irq(clk->irq);
> + if (twd_clk)
> + clk_disable(twd_clk);
While we're here, can we please ensure that the CLK API is properly
respected, and use IS_ERR(twd_clk) to determine of the clock is valid
or not (and not use IS_ERR_OR_NULL()).
More information about the linux-arm-kernel
mailing list