[PATCH 01/10] pinctrl: use postcore_initcall
haojian.zhuang at gmail.com
Thu Oct 18 22:16:12 EDT 2012
On Fri, Oct 19, 2012 at 6:28 AM, Tony Lindgren <tony at atomide.com> wrote:
> * Stephen Warren <swarren at wwwdotorg.org> [121018 15:20]:
>> On 10/18/2012 03:06 AM, Haojian Zhuang wrote:
>> > Since pins are configured in device driver, pinctrl driver should be
>> > loaded by those device driver. module_platform_driver() only declares
>> > pinctrl driver is in module_initcall privilege. Use postcore_initcall
>> > privilege instead.
>> I'm not convinced this is needed; doesn't deferred probe sort out the
>> dependencies correctly?
> I'm a bit concerned about this need too as the trend is towards
> initializing things later than earlier. The drivers/Makefile order
> and deferred probe should be already enough?
> Specifically could you decribe the cases where this issue happens?
> Also check if one of your client drivers has some early initcall
> that's no longer needed.
Yes, the special case is PMIC. Most of PMIC are based on I2C/SPI bus.
It means that I2C/SPI bus driver should be initialized firstly. For example,
we could find that PMIC mfd driver are initialized in subsys init call level.
It means that pinctrl should be initialized earlier than I2C/SPI bus driver.
Otherwise, pins of I2C bus may not be configured as I2C function since
pinctrl driver is module init call level.
More information about the linux-arm-kernel