[PATCH 1/2] ARM: config: sort select statements alphanumerically

Eric Miao eric.y.miao at gmail.com
Mon Oct 15 22:15:52 EDT 2012


On Fri, Oct 12, 2012 at 11:09 PM, Tony Lindgren <tony at atomide.com> wrote:
> * Russell King - ARM Linux <linux at arm.linux.org.uk> [121012 07:44]:
>> On Fri, Oct 12, 2012 at 04:04:28PM +0200, Linus Walleij wrote:
>> > On Fri, Oct 12, 2012 at 3:26 PM, Russell King
>> > <rmk+kernel at arm.linux.org.uk> wrote:
>> >
>> > > As suggested by Andrew Morton:
>> > >
>> > >   This is a pet peeve of mine.  Any time there's a long list of items
>> > >   (header file inclusions, kconfig entries, array initalisers, etc) and
>> > >   someone wants to add a new item, they *always* go and stick it at the
>> > >   end of the list.
>> > >
>> > >   Guys, don't do this.  Either put the new item into a randomly-chosen
>> > >   position or, probably better, alphanumerically sort the list.
>> > >
>> > > lets sort all our select statements alphanumerically.  This commit was
>> > > created by the following perl:
>> >
>> > I applied this and tried to configure the Nomadik defconfig,
>> > and I get this, sadly:
>>
>> Yes, I've just fixed those.  Unfortunately, the patch is soo large that
>> it trips the mailing list size limit, and has to be manually approved,
>> so I'm not sure I can call on the list maintainers again today to do the
>> approval thing.
>
> After applying these two patches and manually running:
>
> $ git checkout-index -f arch/arm/mach-pxa/Kconfig
> $ git checkout-index -f arch/arm/mach-footbridge/Kconfig

Tony, why pxa and footbridge here?

>
> It builds just fine for omaps, so for omaps:
>
> Acked-by: Tony Lindgren <tony at atomide.com>



More information about the linux-arm-kernel mailing list