[PATCH] ARM: OMAP2: UART: fix console UART mismatched runtime PM status
Tony Lindgren
tony at atomide.com
Mon Oct 15 20:01:04 EDT 2012
* Kevin Hilman <khilman at deeprootsystems.com> [121015 16:51]:
> From: Kevin Hilman <khilman at ti.com>
>
> The runtime PM framework assumes that the hardware state of devices
> when initialized is disabled. For all omap_devices, we idle/disable
> device by default. However, the console uart uses a "no idle" option
> during omap_device init in order to allow earlyprintk usage to work
> seamlessly during boot.
>
> Because the hardware is left partially enabled after init (whatever
> the bootloader settings were), the omap_device should later be fully
> initialized (including mux) and the runtime PM framework should be
> told that the device is active, and not disabled so that the hardware
> state is in sync with runtime PM state.
>
> To fix, after the device has been created/registered, call
> omap_device_enable() to finialize init and use pm_runtime_set_active()
> to tell the runtime PM core the device is enabled.
>
> Tested on 2420/n810, 3530/Overo, 3530/Beagle, 3730/OveroSTORM,
> 3730/Beagle-xM, 4460/PandaES.
>
> Reported-by: Paul Walmsley <paul at pwsan.com>
> Suggested-by: Russell King <rmk+kernel at arm.linux.org.uk>
> Cc: Felipe Balbi <balbi at ti.com>
> Cc: Sourav Poddar <sourav.poddar at ti.com>
> Signed-off-by: Kevin Hilman <khilman at ti.com>
Seems to work for my n800:
Tested-by: Tony Lindgren <tony at atomide.com>
More information about the linux-arm-kernel
mailing list