[PATCH] ARM: SAMSUNG: Add naming of s3c64xx-spi devices

Sylwester Nawrocki s.nawrocki at samsung.com
Mon Oct 15 10:58:26 EDT 2012

Hi Heiko,

On 10/02/2012 02:43 PM, Heiko Stübner wrote:
> Commit a5238e360b71 (spi: s3c64xx: move controller information into driver
> data) introduced separate device names for the different subtypes of the
> spi controller but forgot to set these in the relevant machines.
> To fix this introduce a s3c64xx_spi_setname function and populate all
> Samsung arches with the correct names. The function resides in a new
> header, as the s3c64xx-spi.h contains driver platform data and should
> therefore at some later point move out of the Samsung include dir.
> Tested on a s3c2416-based machine.
> Signed-off-by: Heiko Stuebner <heiko at sntech.de>
> Cc: stable at vger.kernel.org

This patch looks good to me. I've tested it on Exynos4412 SoC based
board. And it fixes quite serious problem - broken SPI support on
a all Samsung machs (non-dt) except s3c64xx in mainline v3.6 kernel.

Reviewed-by: Sylwester Nawrocki <s.nawrocki at samsung.com>
Tested-by: Sylwester Nawrocki <s.nawrocki at samsung.com>
(mach-exynos only)

José Miguel, can you confirm it solves the problem for you ?


More information about the linux-arm-kernel mailing list