[PATCH] mmc: mmci: Fixup and cleanup code for DMA handling

Linus Walleij linus.walleij at linaro.org
Fri Oct 12 17:32:31 EDT 2012


On Fri, Oct 12, 2012 at 5:33 PM, Ulf Hansson <ulf.hansson at stericsson.com> wrote:

> From: Ulf Hansson <ulf.hansson at linaro.org>
>
> The cookie is now used to indicate if dma_unmap_sg shall be
> done in post_request. At DMA errors, the DMA job is immediately
> not only terminated but also unmapped. To indicate that this
> has been done the cookie is reset to zero. post_request will
> thus only do dma_umap_sg for requests which has a cookie not set
> to zero.
>
> Some corresponding duplicated code could then be removed and
> moreover some corrections at DMA errors for terminating the same
> DMA job twice has also been fixed.
>
> Signed-off-by: Ulf Hansson <ulf.hansson at linaro.org>
> Signed-off-by: Per Forlin <per.forlin at stericsson.com>

It looks like it's both factoring out code and also adding some unmapping
in hithereto unhandled cases, correct? It looks OK to me now atleast so
Acked-by: Linus Walleij <linus.walleij at linaro.org>

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list