[RFC PATCH] arm: vt8500: Convert irq.c for multiplatform integration
arnd at arndb.de
Wed Oct 10 14:39:57 EDT 2012
On Wednesday 10 October 2012, Tony Prisk wrote:
> I did have one bit I wasn't sure about:
> On Wed, 2012-10-10 at 21:08 +1300, Tony Prisk wrote:
> > This patch converts arch-vt8500/irq.c to MULTI_IRQ_HANDLER and
> > SPARSE_IRQ. IRQ domain is changed from legacy to linear.
> > Also, remove legacy code in include/mach/entry-macro.S and
> > include/mach/irq.h to prepare for multiplatform.
> > Signed-off-by: Tony Prisk <linux at prisktech.co.nz>
> > ---
> > ...
> > diff --git a/arch/arm/mach-vt8500/common.h b/arch/arm/mach-vt8500/common.h
> > index 2b24196..6f2b843 100644
> > --- a/arch/arm/mach-vt8500/common.h
> > +++ b/arch/arm/mach-vt8500/common.h
> > @@ -25,4 +25,7 @@ int __init vt8500_irq_init(struct device_node *node,
> > /* defined in drivers/clk/clk-vt8500.c */
> > void __init vtwm_clk_init(void __iomem *pmc_base);
> > +/* defined in irq.c */
> > +asmlinkage void vt8500_handle_irq(struct pt_regs *regs);
> Should asmlinkage be used here in the header or is it unnecessary?
I think it's not technically needed because the function is not called
from C code anywhere, but IMHO it's better to have it here out of principle.
More information about the linux-arm-kernel