[PATCH] ARM: backtrace: avoid crash on large invalid fp value
Todd Poynor
toddpoynor at google.com
Wed Oct 10 02:46:12 EDT 2012
Invalid frame pointer (signed) -4 <= fp <= -1 defeats check for too high
on overflow.
Signed-off-by: Todd Poynor <toddpoynor at google.com>
---
arch/arm/kernel/stacktrace.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/kernel/stacktrace.c b/arch/arm/kernel/stacktrace.c
index 00f79e5..6315162 100644
--- a/arch/arm/kernel/stacktrace.c
+++ b/arch/arm/kernel/stacktrace.c
@@ -31,7 +31,7 @@ int notrace unwind_frame(struct stackframe *frame)
high = ALIGN(low, THREAD_SIZE);
/* check current frame pointer is within bounds */
- if (fp < (low + 12) || fp + 4 >= high)
+ if (fp < (low + 12) || fp >= high - 4)
return -EINVAL;
/* restore the registers from the stack frame */
--
1.7.7.3
More information about the linux-arm-kernel
mailing list