[PATCH V2 1/2] ARM: remove unnecessary flush of anon pages in flush_dcache_page()
catalin.marinas at arm.com
Mon Oct 8 13:43:40 EDT 2012
On Mon, Oct 08, 2012 at 06:38:27PM +0100, Simon Baatz wrote:
> Hi Catalin,
> On Mon, Oct 08, 2012 at 12:36:07PM +0100, Catalin Marinas wrote:
> > On Sun, Oct 07, 2012 at 12:29:11PM +0100, Simon Baatz wrote:
> > > On non-aliasing VIPT D-caches, there is no need to flush the kernel
> > > mapping of anon pages in flush_dcache_page() directly. If the page is
> > > mapped as executable later, the necessary D/I-cache flush will be done
> > > in __sync_icache_dcache().
> > >
> > > Signed-off-by: Simon Baatz <gmbnomis at gmail.com>
> > > Cc: Catalin Marinas <catalin.marinas at arm.com>
> > > Cc: Russell King <linux at arm.linux.org.uk>
> > Acked-by: Catalin Marinas <catalin.marinas at arm.com>
> Thanks for the ack! However, while this improvement is nice to have,
> I care more about fixing that nasty data corruption on VIVT/VIPT
> aliasing caches with the second patch. In case you cannot offer a
> Acked-by or Reviewed-by for the patch for technical reasons, could
> you please explain your reservations against the fix?
I was busy with other things today and didn't have time to get back to
this thread. I'll post a question though.
More information about the linux-arm-kernel