ARM: OMAP: fix new sparse warnings

Paul Walmsley paul at
Sun Oct 7 21:42:59 EDT 2012

Here's an updated version of this one that drops the debug-devices.c 
change.   That will be dealt with in a separate patch.

- Paul

From: Paul Walmsley <paul at>
Date: Sun, 7 Oct 2012 13:10:00 -0600
Subject: [PATCH] ARM: OMAP: omap3evm: fix new sparse warning

Commit e54adb1e79762d3591459e5b0e9b9ff578e33fdb ("ARM: OMAP: omap3evm:
cleanup revision bits") adds a new sparse[1] warning:

arch/arm/mach-omap2/board-omap3evm.c:90:4: warning: symbol 'get_omap3_evm_rev' was not declared. Should it be static?

This symbol no longer appears to be used outside this file, so mark it
static and remove the export.



Signed-off-by: Paul Walmsley <paul at>
Cc: Igor Grinberg <grinberg at>
Cc: Tony Lindgren <tony at>
 arch/arm/mach-omap2/board-omap3evm.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm/mach-omap2/board-omap3evm.c b/arch/arm/mach-omap2/board-omap3evm.c
index c64e565..184ef21 100644
--- a/arch/arm/mach-omap2/board-omap3evm.c
+++ b/arch/arm/mach-omap2/board-omap3evm.c
@@ -88,11 +88,10 @@ enum {
 static u8 omap3_evm_version;
-u8 get_omap3_evm_rev(void)
+static u8 get_omap3_evm_rev(void)
 	return omap3_evm_version;
 static void __init omap3_evm_get_revision(void)

More information about the linux-arm-kernel mailing list