[PATCH] ARM: kirkwood: DT board setup for Network Space v2 and parents

[Simon Guinot]

On Wed, Oct 03, 2012 at 05:43:10PM +0200, Andrew Lunn wrote:
> On Wed, Oct 03, 2012 at 05:14:30PM +0200, Simon Guinot wrote:
> > This patch adds DT board setup for LaCie Network Space v2 and parents,
> > based the Marvell Kirkwood 6281 SoC. This includes Network Space (Max)
> > v2 and Internet Space v2.
> 
> Hi Simon
> 
> At a first look, this looks good. Also nice to see you use the new
> gpio-fan binding.

Hi Andrew,

It is nice to have this binding. It works fine.

> 
> > --- a/arch/arm/mach-kirkwood/board-dt.c
> > +++ b/arch/arm/mach-kirkwood/board-dt.c
> > @@ -96,6 +96,11 @@ static void __init kirkwood_dt_init(void)
> >  	if (of_machine_is_compatible("keymile,km_kirkwood"))
> >  		km_kirkwood_init();
> >  
> > +	if (of_machine_is_compatible("lacie,inetspace_v2") ||
> > +	    of_machine_is_compatible("lacie,netspace_v2") ||
> > +	    of_machine_is_compatible("lacie,netspace_max_v2"))
> > +		ns2_init();
> > +
> >  	of_platform_populate(NULL, kirkwood_dt_match_table,
> >  			     kirkwood_auxdata_lookup, NULL);
> 
> I'm not a DT policy expert. Could this be one compatibility string for
> all the boards? Maybe ask on the DT mainline list?

Maybe I could use "lacie,ns2_common" as a compatibility string. But this
does not match any existing device. I don't know if it is correct.

> 
> > +#define NETSPACE_V2_GPIO_BLUE_LED_SLOW	29
> > +#define NETSPACE_V2_GPIO_BLUE_LED_CMD	30
> > +
> > +static struct ns2_led ns2_led_pins[] = {
> > +	{
> > +		.name	= "ns_v2:blue:sata",
> > +		.cmd	= NETSPACE_V2_GPIO_BLUE_LED_CMD,
> > +		.slow	= NETSPACE_V2_GPIO_BLUE_LED_SLOW,
> > +	},
> > +};
> > +
> > +static struct ns2_led_platform_data ns2_leds_data = {
> > +	.num_leds	= ARRAY_SIZE(ns2_led_pins),
> > +	.leds		= ns2_led_pins,
> > +};
> > +
> > +static struct platform_device ns2_leds = {
> > +	.name		= "leds-ns2",
> > +	.id		= -1,
> > +	.dev		= {
> > +		.platform_data	= &ns2_leds_data,
> > +	},
> > +};
> 
> Have you thought about adding a DT binding for this driver?

Yes. I am on it.

> 
> It would be nice if you could respin the patches for -rc1, when it
> comes out. There are changes to Makefile.boot at least required.

OK. I will.

Note that this patch is based against the branch kirkwood/boards from
the git repository git://git.infradead.org/users/jcooper/linux.git. Is
that correct ?

Thanks.

Simon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20121004/b1121644/attachment.sig>