[PATCH] arm: include linux/sched.h in syscall.h

Will Deacon will.deacon at arm.com
Tue Oct 2 11:52:55 EDT 2012


On Tue, Oct 02, 2012 at 04:43:44PM +0100, Wade Farnsworth wrote:
> > On Mon, Oct 01, 2012 at 09:10:08PM +0100, Wade Farnsworth wrote:
> >> task_thread_info() is defined in linux/sched.h.  Explicitly include this
> >> file in arch/arm/include/asm/syscall.h.  This fixes an lttng-modules compile error.
> >
> > Can you be more specific about the error? From your description, it sounds
> > like it should be fixed in lttng rather than here.
> >
> My apologies for the lack of clarity.
> 
> My syscall tracing patch introduces a compile bug in lttng-modules when 
> the latter calls syscall_get_nr(), similar to the following:
> 
> <path-to-linux>/arch/arm/include/asm/syscall.h:21:2: error: implicit 
> declaration of function 'task_thread_info' 
> [-Werror=implicit-function-declaration]
> 
> The issue is that we are using task_thread_info() in the 
> syscall_get_nr() function in asm/syscall.h, but not explicitly including 
> sched.h from this file, so we can expect this bug might surface any time 
> that syscall_get_nr() is called.
> 
> Hopefully that clarifies things somewhat.

Yep, thanks. Your patch sounds like the right thing to do, but please
include the compiler error in your commit log.

Acked-by: Will Deacon <will.deacon at arm.com>

Will



More information about the linux-arm-kernel mailing list