[PATCH 1/4] mfd: ab8500: add devicetree support for fuelgauge
Lee Jones
lee.jones at linaro.org
Mon Oct 1 06:22:28 EDT 2012
Sorry, some mistakes:
> > From: "Rajanikanth H.V" <rajanikanth.hv at stericsson.com>
> >
> > - This patch adds device tree support for fuelguage driver
> > - optimize bm devices platform_data usage and of_probe(...)
> > Note: of_probe() routine for battery managed devices is made
> > common across all bm drivers.
Spelling errors in here.
> > + dev_err(dev, "invalid battery-info node\n");
> > + return -EINVAL;
> > + }
> > + if (of_property_read_bool(np_bat_supply,
> > + "thermistor-on-batctrl") == false){
>
> Replace with:
> if (of_get_property(np_bat_supply, "thermistor-on-batctr", NULL))
> np_bat_supply = true;
This should be:
if (of_get_property(np_bat_supply, "thermistor-on-batctr", NULL))
thermistor = NTC_INTERNAL;
else
thermistor = NTC_EXTERNAL;
> <remove>
>
> > + dev_warn(dev, "missing property thermistor-on-batctrl\n");
> > + thermistor = NTC_EXTERNAL;
> > + }
>
> </remove>
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
More information about the linux-arm-kernel
mailing list