[PATCH 4/6 v5] arm highbank: add support for pl320 IPC
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Tue Nov 27 11:12:50 EST 2012
Dear Mark Langsdorf,
On Tue, 27 Nov 2012 09:04:32 -0600, Mark Langsdorf wrote:
> +int ipc_transmit(u32 *data);
ipc_transmit() looks to me like a way to generic name to be exposed to
the entire kernel.
> +extern int pl320_ipc_register_notifier(struct notifier_block *nb);
> +extern int pl320_ipc_unregister_notifier(struct notifier_block *nb);
Why some "extern" here? You don't have these for the other functions in
this header file.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
More information about the linux-arm-kernel
mailing list