[PATCH] clk: ux500: assume PRCC clocks are off by default

Linus Walleij linus.walleij at linaro.org
Tue Nov 27 09:16:20 EST 2012


On Tue, Nov 27, 2012 at 2:58 PM, Ulf Hansson <ulf.hansson at linaro.org> wrote:
> On 27 November 2012 14:51, Linus Walleij <linus.walleij at stericsson.com> wrote:
>> From: Linus Walleij <linus.walleij at linaro.org>

>> So instead assume that the PRCC clocks are *not* on, and
>> everything starts working. This may cause a few extra writes
>> to the enable registers but it's worth it. We cannot read
>> the status registers to find out if the clock is on at
>> this point as that means we first have to turn on the
>> clock to the peripheral cluster.
>>
>> Reported-by: Lee Jones <lee.jones at linaro.org>
>> Cc: Ulf Hansson <ulf.hansson at linaro.org>
>> Cc: Philippe Begnic <philippe.begnic at st.com>
>> Cc: Per Forlin <per.forlin at stericsson.com>
>> Signed-off-by: Linus Walleij <linus.walleij at linaro.org>
>> ---
>> Mike: this needs to go into v3.7. (Yes, sorry for not seeing
>> this earlier, but the problem did manifest itself in very
>> strange ways.) If v3.7 is not possible, make sure to add the
>
> Hold on!
>
> I see what you are trying to solve. But the next problem when going
> ahead with this patch is that some clocks, which are default on, will
> be kept on unless some client explicit disables it. This is not OK. I
> will get back to you with some more ideas how to proceed.

OK ... well that means if we don't come up with a better solution
we need to choose the lesser of two evils:

- Apply this and get a power regression

- Not apply this and get a GPIO regression which cascades
  to child devices, for example STMPE keypad and SD Card
  detect on older boards is
  not working at all without this.

So let's see if we can fix the perfect patch to avoid having to
choose...

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list