[PATCH] ARM: implement optimized percpu variable access
Russell King - ARM Linux
linux at arm.linux.org.uk
Fri Nov 23 12:12:18 EST 2012
On Fri, Nov 23, 2012 at 11:06:07AM -0600, Rob Herring wrote:
> On 11/22/2012 05:34 AM, Will Deacon wrote:
> > Hi Rob,
> >
> > On Sun, Nov 11, 2012 at 03:20:40AM +0000, Rob Herring wrote:
> >> From: Rob Herring <rob.herring at calxeda.com>
> >>
> >> Use the previously unused TPIDRPRW register to store percpu offsets.
> >> TPIDRPRW is only accessible in PL1, so it can only be used in the kernel.
> >>
> >> This saves 2 loads for each percpu variable access which should yield
> >> improved performance, but the improvement has not been quantified.
> >>
> >> Signed-off-by: Rob Herring <rob.herring at calxeda.com>
> >> ---
> >> arch/arm/include/asm/Kbuild | 1 -
> >> arch/arm/include/asm/percpu.h | 44 +++++++++++++++++++++++++++++++++++++++++
> >> arch/arm/kernel/smp.c | 3 +++
> >> 3 files changed, 47 insertions(+), 1 deletion(-)
> >> create mode 100644 arch/arm/include/asm/percpu.h
> >
> > Russell pointed out to me that this patch will break on v6 CPUs if they don't
> > have the thread ID registers and we're running with SMP_ON_UP=y. Looking at
> > the TRMs, the only case we care about is 1136 < r1p0, but it does indeed break
> > there (I have a board on my desk).
>
> Are there any non ARM Ltd. cores without v6K we need to worry about? I
> wouldn't think there are many 1136 < r1p0 out there (your desk being an
> obvious exception).
And my desk...
More information about the linux-arm-kernel
mailing list