[PATCH 06/29] usb: host: ehci-mv: fix clk APIs

Alan Stern stern at rowland.harvard.edu
Fri Nov 23 11:06:15 EST 2012


On Wed, 21 Nov 2012, Chao Xie wrote:

> From: Chao Xie <chao.xie at marvell.com>
> 
> Signed-off-by: Chao Xie <xiechao.mail at gmail.com>

I don't like patches with no patch description.  You should write 
something here, explaining why the change is needed.  What's wrong with 
the clk APIs?

The same hold for your other patches, except perhaps the trivial one 
that removes an unused local variable definition.

Alan Stern




More information about the linux-arm-kernel mailing list