[PATCH 1/8] DMA: PL330: use prefix in reg names to build under x86
viresh kumar
viresh.kumar at linaro.org
Fri Nov 23 10:51:44 EST 2012
On Fri, Nov 23, 2012 at 8:38 PM, Davide Ciminaghi <ciminaghi at gnudd.com> wrote:
> From: Alessandro Rubini <rubini at gnudd.com>
>
> This driver would not compile if ARM_AMBA is selected under x86,
> because "CS" and "DS" are already defined there. But AMBA
> is used in the x86 world by a PCI-to-AMBA bridge, to be submitted.
>
> The patch adds the "PL330_" prefix to all register and bit fields,
> so it can be built by randomconfig after ARM_AMBA appears within x86.
>
> Signed-off-by: Alessandro Rubini <rubini at gnudd.com>
> Acked-by: Giancarlo Asnaghi <giancarlo.asnaghi at st.com>
Hi Davide,
Its impossible to review due to obvious reasons :)
Though git provides an option to people to review such stuff easily.
git diff HEAD^.. --word-diff
and HEAD being the commit in discussion.
Problem, is people reviewing it need to apply it and not everybody
can do that. Don't know if adding this diff after the three --- line,
which form the non-commit log would be the right solution ?
--
viresh
More information about the linux-arm-kernel
mailing list