[PATCH 1/4] mfd: ab8500: add devicetree support for fuelgauge

Lee Jones lee.jones at linaro.org
Fri Nov 23 04:50:00 EST 2012


> On Fri, Nov 23, 2012 at 12:13:44AM +0530, Rajanikanth H.V wrote:
> [...]
> > +/*
> > + * Note that the batres_vs_temp table must be strictly sorted by falling
> > + * temperature values to work.
> > + */
> > +struct batres_vs_temp temp_to_batres_tbl_thermistor[] = {
> 
> It must be static.
> 
> [..]
> > +struct batres_vs_temp temp_to_batres_tbl_ext_thermistor[] = {
> 
> Ditto.
> 
> > +	{ 60, 300},
> > +	{ 30, 300},
> > +	{ 20, 300},
> > +	{ 10, 300},
> > +	{ 00, 300},
> > +	{-10, 300},
> > +	{-20, 300},
> > +};
> > +
> > +/* battery resistance table for LI ION 9100 battery */
> > +struct batres_vs_temp temp_to_batres_tbl_9100[] = {
> 
> Ditto.
> 
> There are other issues, which I fixed in my tree for the previous series.
> So the previous series already merged, please post patches on top of it.

Ah, I see now. My apologies, I'll re-comment.

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog



More information about the linux-arm-kernel mailing list