[PATCH 1/3] CLK: uninline clk_prepare() and clk_unprepare()
viresh.kumar at linaro.org
Thu Nov 22 05:08:52 EST 2012
On 22 November 2012 15:00, Russell King - ARM Linux
<linux at arm.linux.org.uk> wrote:
> Err, no you haven't, not with that grep. What you've found are the places
> which enable this, and say "yes, I have clk_prepare".
> What HAVE_CLK_PREPARE is about though is providing a transition path between
> drivers using clk_prepare() to platforms which _don't_ have a clk_prepare()
> implementation - and when it's unset, it provides a default implementation.
Just to make it more clear:
Categories of platforms:
- COMMON_CLK=y: For them it is mandatory to have clk_[un]prepare
- HAVE_CLK=n: dummy implementation suggested in this patch is enough for it.
Even existing implementation too.
- HAVE_CLK_PREPARE=y: Platforms must have their own implementation of
this routine and so a prototype is enough in clk.h
- HAVE_CLK_PREPARE=n: This is the problematic place. Who will provide
implementation of dummy routine here? With current patch
nor clk.h is providing that.
Sorry for not reviewing it properly :(
More information about the linux-arm-kernel