[PATCH v5 05/10] pinctrl: single: support pinconf generic

Tony Lindgren tony at atomide.com
Wed Nov 21 19:08:00 EST 2012


* Haojian Zhuang <haojian.zhuang at gmail.com> [121117 20:53]:
> On Sat, Nov 17, 2012 at 8:43 AM, Tony Lindgren <tony at atomide.com> wrote:
> 
> I agree that returning data directly would be easy for the usage in
> device driver. Let's define it as "data >> shift".
> Is it OK?

Yes returning data >> shift makes sense to me from consumer driver
point of view, so I guess then it's just what I too suggested:

data = (data >> arg.bits.shift) & arg.bits.mask;
*config = data;

Or did I miss something? 

Regards,

Tony



More information about the linux-arm-kernel mailing list