[PATCH] ARM: Kirkwood: Update PCI-E fixup

Jason Gunthorpe jgunthorpe at obsidianresearch.com
Wed Nov 21 12:33:57 EST 2012


On Wed, Nov 21, 2012 at 04:05:55PM +0100, Thomas Petazzoni wrote:
> Dear Jason Gunthorpe,
> 
> On Wed, 21 Nov 2012 00:19:06 -0700, Jason Gunthorpe wrote:
> 
> > +/* The root complex has a hardwired class of PCI_CLASS_MEMORY_OTHER, when it
> > +   is operating as a root complex this needs to be switched to
> > +   PCI_CLASS_BRIDGE_HOST or Linux will errantly try to process the BAR's on
> > +   the device. Decoding setup is handled by the orion code. */
> 
> Sorry for this unique silly review comment, but this comment does not
> comply with the kernel CodingStyle for multicomments. It should be:

Ok! Though I'm surprised checkpatch didn't complain?

Jason



More information about the linux-arm-kernel mailing list