[PATCH V4 5/5] arm: mvebu: Added SMP support for Armada XP

Will Deacon will.deacon at arm.com
Tue Nov 20 12:01:27 EST 2012


On Tue, Nov 20, 2012 at 04:49:29PM +0000, Gregory CLEMENT wrote:
> On 11/20/2012 05:40 PM, Will Deacon wrote:
> > 
> > ENTRY(armada_xp_secondary_startup)
> > 	ldr     r0, =ARMADA_XP_CFB_BASE
> > 	mrc     p15, 0, r1, c0, c0, 5
> > 	and     r1, r1, #0xF
> > 	adr	lr, BSYM(secondary_startup)
> > 
> > 	/* Fallthrough */
> > 
> > ENTRY(ll_set_cpu_coherent)
> > ...
> > ENDPROC(ll_set_cpu_coherent)
> > ENDPROC(armada_xp_secondary_startup)
> > 
> > what do you think?
> > 
> 
> I prefer to keep them separate, as we can use coherency without SMP.
> That's why I create the coherency_ll.S file instead of putting everything
> in this file.

Hmm, can you elaborate a bit more on coherency without SMP please? Do these
controls also affect IO coherency?

Will



More information about the linux-arm-kernel mailing list