[PATCH 1/3] CLK: uninline clk_prepare() and clk_unprepare()
Dmitry Torokhov
dmitry.torokhov at gmail.com
Tue Nov 20 04:57:57 EST 2012
On Tue, Nov 20, 2012 at 09:32:42AM +0000, Russell King - ARM Linux wrote:
> On Tue, Nov 20, 2012 at 01:22:17AM -0800, Dmitry Torokhov wrote:
> > We'll need to invoke clk_unprepare() via a pointer in our devm_*
> > conversion so let's uninline the pair.
>
> NAK. This breaks non-common clock using implementations.
As Viresh mentioned I provided stubs for case when we do not have
CONFIG_HAVE_CLK, so I am not sure how I'll break these platforms, but I
am certainly open for suggestions.
>
> Why do you need to call this function via a pointer? That sounds absurd.
devres framework takes and stores a pointer to a "destructor" which will
be used later.
Thanks.
--
Dmitry
More information about the linux-arm-kernel
mailing list